This repository has been archived by the owner on Aug 13, 2021. It is now read-only.
SQLite3 Adapter #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't try too much, including where conditions which are still untried
find where criteria do not match current waterline api. must be migrated
refactoring whole method for better logical structuring and new waterline where format
Criteria tree evaluated recursively, includes all v1 operators, unsure about JSON column type
All criteria pass smoke tests (No real testing though)
Sqlite is not made for concurrent writes - refactor to only spawn one write client
fix some bugs, discover others
Was coded as 'IN', added 'NOT'
Adding associations interface tests
Waterline API v1 rewrite
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite3 Adapter
First of all, I'd like to thank the Sails.js team for creating such an amazing framework. I ended up creating a SQLite3 adapter for Waterline because I needed a lightweight database that was going to run on an embedded device (BeagleBone Black) and it seemed like there was no support for it.
Again, special thanks to the developers and community of Sails.js and Node!
Important Note
Please do not merge this yet as the code is definitely not ready for primetime. None of the unit tests have been written for it and lot of the code was loosely based on the PostgreSQL adapter which may or may not cause problems with SQLite. I am submitting the pull request to let everyone know that the SQLite adapter is under active development and to eliminate duplicate efforts (and possibly get some helping hand on my end).