Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scroll issue in flutter integration driver #2227

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

MummanaSubramanya
Copy link
Contributor

@MummanaSubramanya MummanaSubramanya commented Aug 29, 2024

Change list

This PR address the issue AppiumTestDistribution/appium-flutter-integration-driver#88

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@mykola-mokhnach
Copy link
Contributor

@MummanaSubramanya I can also observe one flutter integration test failing in CI env: https://github.com/appium/java-client/actions/runs/10611872941/job/29413196070?pr=2227. Could you please check if it needs to be updated together with this PR?

@MummanaSubramanya
Copy link
Contributor Author

@MummanaSubramanya I can also observe one flutter integration test failing in CI env: https://github.com/appium/java-client/actions/runs/10611872941/job/29413196070?pr=2227. Could you please check if it needs to be updated together with this PR?

test fixed

@mykola-mokhnach mykola-mokhnach merged commit f8ef9c1 into appium:master Aug 29, 2024
6 of 7 checks passed
@KazuCocoa KazuCocoa added the size:S contribution size: S label Sep 6, 2024
@jlipps
Copy link
Member

jlipps commented Sep 6, 2024

Hi @MummanaSubramanya , congrats, the Appium project wants to compensate you for this (and perhaps other) contribution(s) this month! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you!

@MummanaSubramanya
Copy link
Contributor Author

Hi @MummanaSubramanya , congrats, the Appium project wants to compensate you for this (and perhaps other) contribution(s) this month! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you!

Hi @jlipps, thank you so much for the kind gesture and support! I gratefully accept the compensation via OpenCollective. My OpenCollective account name is MummanaSubramanya

I look forward to contributing even more to the Appium community!

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S contribution size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants