fix: AppiumClientConfig#readTimeout to call super.readTimeout #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
mykola-mokhnach
approved these changes
Jul 11, 2023
4 tasks
asolntsev
added a commit
to selenide/selenide
that referenced
this pull request
Oct 17, 2023
1. Obviously, 20 seconds was too short for running Simulator and installing the app. 2. But it didn't affect our tests because of bug appium/java-client#1959 in Appium. This bug was fixed in Appium 8.6.0, and our tests started failing with timeout exception.
asolntsev
added a commit
to selenide/selenide
that referenced
this pull request
Oct 18, 2023
1. Obviously, 20 seconds was too short for running Simulator and installing the app. 2. But it didn't affect our tests because of bug appium/java-client#1959 in Appium. This bug was fixed in Appium 8.6.0, and our tests started failing with timeout exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
https://github.com/appium/java-client/pull/1747/files#r1260247871
Bad copy & paste thing.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Should call super.readTimeout instead of super.connectionTimeout in readTimeout