Fix for AUTO_WEBVIEW in MobileCapabilityType #1958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed value for AUTO_WEBVIEW from 'autoWebview' to 'autoWebView'
FiniH
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
|
valfirst
reviewed
Jul 11, 2023
| @@ -85,7 +85,7 @@ public interface MobileCapabilityType extends CapabilityType { | |||
| /** | |||
| * Move directly into Webview context. Default false. | |||
| */ | |||
| String AUTO_WEBVIEW = "autoWebview"; | |||
| String AUTO_WEBVIEW = "autoWebView"; | |||
There was a problem hiding this comment.
It doesn't seem to be a valid fix
|
We should probably deprecate this whole interface for good. |
|
The class has been marked for deprecation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed value for AUTO_WEBVIEW from 'autoWebview' to 'autoWebView'.
Change list
Please provide briefly described change list which are you going to propose.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub
I realized while using the MobileCapabilityType.AUTO_WEBVIEW that the value for the type is 'autoWebview' and not 'autoWebView'. The latter seems to be the correct value though as my app test actually crashed on me until I used the 'autoWebView' string instead of the type itself. This is why I propose this change to be in the project itself to I can use the type in the future and not depend on the 'autoWebView' capability using the string anymore.