Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17413: ulog replay should copy SolrQueryRequest #2765

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SOLR-17413: ulog replay should copy SolrQueryRequest #2765

wants to merge 2 commits into from

Commits on Oct 15, 2024

  1. SOLR-17413: ulog replay should copy SolrQueryRequest 

    SolrQueryRequest is a non-threadsafe type, but was being shared across
executor threads during UpdateLog replay.  This introduces a number of
issues, not the least being a ConcurrentModificationException if
multiple threads happen to tweak the request 'context' simultaneously.

This commit fixes this issue by giving each executor thread a unique
LocalSolrQueryRequest instance to use.
    @gerlowskija
    gerlowskija committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    96f6c30 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Address review comments, rd 1

    @gerlowskija
    gerlowskija committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4772729 View commit details
    Browse the repository at this point in the history