-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-68] Unify the table structure and table fields in backend and frontend ui sections #16544
Conversation
...er-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java
Fixed
Show fixed
Hide fixed
...in/java/org/apache/dolphinscheduler/service/expand/TimePlaceholderResolverExpandService.java
Dismissed
Show dismissed
Hide dismissed
...in/java/org/apache/dolphinscheduler/service/expand/TimePlaceholderResolverExpandService.java
Dismissed
Show dismissed
Hide dismissed
...in/java/org/apache/dolphinscheduler/service/expand/TimePlaceholderResolverExpandService.java
Dismissed
Show dismissed
Hide dismissed
1d68dba
to
7ffe0ef
Compare
for (String strProcessInstanceId : processInstanceIdArray) { | ||
int processInstanceId = Integer.parseInt(strProcessInstanceId); | ||
for (String strWorkflowInstanceId : workflowInstanceIdArray) { | ||
int workflowInstanceId = Integer.parseInt(strWorkflowInstanceId); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
execService.controlWorkflowInstance(loginUser, processInstanceId, executeType); | ||
log.info("Success do action {} on workflowInstance: {}", executeType, processInstanceId); | ||
execService.controlWorkflowInstance(loginUser, workflowInstanceId, executeType); | ||
log.info("Success do action {} on workflowInstance: {}", executeType, workflowInstanceId); |
Check failure
Code scanning / CodeQL
Log Injection High
user-provided value
+ "reason: " + e.getMessage()); | ||
log.error("Failed do action {} on workflowInstance: {}, error: {}", executeType, processInstanceId, e); | ||
log.error("Failed do action {} on workflowInstance: {}, error: {}", executeType, workflowInstanceId, e); |
Check failure
Code scanning / CodeQL
Log Injection High
user-provided value
for (String strProcessInstanceId : processInstanceIdArray) { | ||
int processInstanceId = Integer.parseInt(strProcessInstanceId); | ||
for (String strWorkflowInstanceId : workflowInstanceIdArray) { | ||
int workflowInstanceId = Integer.parseInt(strWorkflowInstanceId); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
} catch (Exception e) { | ||
log.error("Delete workflow instance: {} error", strProcessInstanceId, e); | ||
log.error("Delete workflow instance: {} error", strWorkflowInstanceId, e); |
Check failure
Code scanning / CodeQL
Log Injection High
user-provided value
import lombok.Data; | ||
import lombok.EqualsAndHashCode; | ||
|
||
@EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
DagData.canEqual
@@ -30,19 +31,20 @@ | |||
/** | |||
* task instance request | |||
*/ | |||
@EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
PageQueryDto.canEqual
8686e31
to
6b50d70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍 , only have one issue I am not sure
|
||
UPDATE t_ds_task_definition SET task_type = 'SUB_WORKFLOW' WHERE task_type = 'SUB_PROCESS'; | ||
UPDATE t_ds_task_definition_log SET task_type = 'SUB_WORKFLOW' WHERE task_type = 'SUB_PROCESS'; | ||
UPDATE t_ds_task_definition SET task_params = replace(task_params, 'processDefinitionCode', 'workflowDefinitionCode') where task_type = 'SUB_WORKFLOW'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to upgrade t_ds_task_definition_log
.
And Dynamic task need to upgrade too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
||
UPDATE t_ds_task_definition SET task_type = 'SUB_WORKFLOW' WHERE task_type = 'SUB_PROCESS'; | ||
UPDATE t_ds_task_definition_log SET task_type = 'SUB_WORKFLOW' WHERE task_type = 'SUB_PROCESS'; | ||
UPDATE t_ds_task_definition SET task_params = replace(task_params, 'processDefinitionCode', 'workflowDefinitionCode') where task_type = 'SUB_WORKFLOW'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Quality Gate failedFailed conditions |
Purpose of the pull request
Brief change log
close #16515
close #16525
@DisableIfTestFails
annotation toe2e-test
andapi-test
to the test class, all tests after the first failed one are disabled for better debugging. JunitVerify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md