-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-66][k8s] Support User-customized K8s YAML Pod #16477
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
First you need to create a DSIP. |
...-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/AbstractK8sOperation.java
Fixed
Show fixed
Hide fixed
...-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/AbstractK8sOperation.java
Fixed
Show fixed
Hide fixed
Yes you need to create a DSIP, and provide detailed design, rather then directly submit a PR. |
@Mighten Please modify the associated issue number |
* Added `YamlUtils` with `jackson-dataformat-yaml`(new dependency in `pom.xml`)* * Updated `K8sUtils` with default namespace injection* * Added user-customized YAML task mode, with frontend and backend*
Quality Gate failedFailed conditions |
Closing for no plans to do this. |
Purpose of the pull request
This pull request adds user-customized YAML support for Kubernetes Pod task,
and aims to close: #16482
Brief change log
YamlUtils
withjackson-dataformat-yaml
(new dependency inpom.xml
)K8sUtils
with default namespace injectionVerify this pull request
This change added tests and can be verified as follows:
Added
YamlUtilsTest
to verifyYamlUtils
Added
K8sUtilsTest
to verify updates forK8sUtils
Manually verified the user-customized YAML task mode using both the web page and IDE output:
Switch on the Custom Template mode, and paste Kubernetes YAML file content:
Conclusion: The user-customized YAML mode works correctly in the frontend.
Online, Start the current workflow and review the log of the current task instance:
Conclusion: The user-customized YAML mode works correctly in the backend.
Review the pod output parameters parsed from the log in the IDE console (these are not listed in the task instance log window):
Conclusion: The user-customized YAML mode correctly parses the output values from the log.