-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-54][Master] Use ClusterManager to manage the cluster in master #16263
[DSIP-54][Master] Use ClusterManager to manage the cluster in master #16263
Conversation
d42e876
to
7bef33a
Compare
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...ler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/MasterServer.java
Fixed
Show fixed
Hide fixed
...ler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerServer.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16263 +/- ##
============================================
- Coverage 41.17% 41.07% -0.11%
+ Complexity 5093 5083 -10
============================================
Files 1391 1396 +5
Lines 43803 43674 -129
Branches 4645 4621 -24
============================================
- Hits 18038 17938 -100
+ Misses 23997 23976 -21
+ Partials 1768 1760 -8 ☔ View full report in Codecov by Sentry. |
7bef33a
to
61210f3
Compare
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
|
||
@Data | ||
@SuperBuilder | ||
@EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
BaseServerMetadata.canEqual
|
||
@Data | ||
@SuperBuilder | ||
@EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
BaseServerMetadata.canEqual
9fa1ea9
to
55750ba
Compare
55750ba
to
a8ed188
Compare
a8ed188
to
f26012b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍🏻
Please retry analysis of this Pull-Request directly on SonarCloud |
Purpose of the pull request
close #16262
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md