Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shasum regex #331

Closed
wants to merge 1 commit into from
Closed

fix: shasum regex #331

wants to merge 1 commit into from

Conversation

in0rdr
Copy link
Contributor

@in0rdr in0rdr commented Jul 7, 2023

Extracting the shasum fails on my machine:

TASK [ansible-vault : Download Vault (local) → https://releases.hashicorp.com/vault/1.12.0+ent/vault_1.12.0+ent_linux_amd64.zip] ************************
fatal: [vlt-bootstrap-vlt-01 -> 127.0.0.1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: No first item, sequence was empty.. No first item, sequence was empty.\n\nThe error appears to be in '***': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: \"Download Vault (local) → {{ vault_zip_url }}\"\n  ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n    with_items:\n      - {{ foo }}\n\nShould be written as:\n\n    with_items:\n      - \"{{ foo }}\"\n"}

Maybe it has to do with the fact that vault_pkg contains dots (.) which could mess up the regex? Not sure though.

In any case, testing for OS and arch should be sufficient, because the shasum file only contains hash sums for the same Vault version?

What do you think @gardar?

@in0rdr
Copy link
Contributor Author

in0rdr commented Jul 7, 2023

So seems like the original version works fine if I install from the OS repo with slightly changed variables:

vault_version: 'enterprise-1.11.2+ent'
vault_install_hashi_repo: true

The shasum check works fine when installing from the repo.

I will close this PR and go with that version (OS/repo package).

@in0rdr in0rdr closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant