Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface write failures through Body.Writer.flush #247

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

anmonteiro
Copy link
Owner

No description provided.

@anmonteiro anmonteiro merged commit 554575c into master Aug 27, 2024
3 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/surface-write-errors-on-flush branch August 27, 2024 06:08
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Sep 4, 2024
CHANGES:

- surface write failures through `Body.Writer.flush`
  ([anmonteiro/ocaml-h2#247](anmonteiro/ocaml-h2#247))
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Sep 4, 2024
CHANGES:

- h2: surface (body) write failures through `flush`
  ([anmonteiro/ocaml-h2#247](anmonteiro/ocaml-h2#247))
    - `Body.Writer.flush` now takes a callback of the type
       ``([ `Written | ` Closed] -> unit)``, informing the caller whether the
       previous writes have been written or whether the output channel was
       closed.
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Sep 5, 2024
CHANGES:

- h2: surface (body) write failures through `flush`
  ([anmonteiro/ocaml-h2#247](anmonteiro/ocaml-h2#247))
    - `Body.Writer.flush` now takes a callback of the type
       ``([ `Written | ` Closed] -> unit)``, informing the caller whether the
       previous writes have been written or whether the output channel was
       closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant