Fix errors caused by empty lists

acoustid · Feb 22, 2024 · 8575c09 · 8575c09
1 parent c72f352
commit 8575c09
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/pkg/fpstore/cache.go b/pkg/fpstore/cache.go
@@ -33,6 +33,10 @@ func (c *RedisFingerprintCache) cacheKey(id uint64) string {
 }
 
 func (c *RedisFingerprintCache) GetMulti(ctx context.Context, ids []uint64) (map[uint64]*pb.Fingerprint, error) {
+	if len(ids) == 0 {
+		return nil, nil
+	}
+
 	keys := make([]string, len(ids))
 	for i, id := range ids {
 		keys[i] = c.cacheKey(id)

diff --git a/pkg/fpstore/service.go b/pkg/fpstore/service.go
@@ -111,6 +111,10 @@ func (s *FingerprintStoreService) getFingerprint(ctx context.Context, id uint64)
 func (s *FingerprintStoreService) getFingerprints(ctx context.Context, ids []uint64) (map[uint64]*pb.Fingerprint, error) {
 	logger := zerolog.Ctx(ctx)
 
+	if len(ids) == 0 {
+		return nil, nil
+	}
+
 	cachedFingerprints, err := s.cache.GetMulti(ctx, ids)
 	if err != nil {
 		logger.Err(err).Msg("failed to get fingerprints from cache")
@@ -233,6 +237,10 @@ func (s *FingerprintStoreService) Search(ctx context.Context, req *pb.SearchFing
 
 	logger.Debug().Int("candidates", len(candidateIds)).Msg("received candidates")
 
+	if len(candidateIds) == 0 {
+		return &pb.SearchFingerprintResponse{}, nil
+	}
+
 	results, err := s.compareFingerprints(ctx, req.Fingerprint, candidateIds, req.MinScore)
 	if err != nil {
 		return nil, err

diff --git a/pkg/fpstore/store.go b/pkg/fpstore/store.go
@@ -100,6 +100,9 @@ func (s *PostgresFingerprintStore) Get(ctx context.Context, id uint64) (*pb.Fing
 }
 
 func (s *PostgresFingerprintStore) GetMulti(ctx context.Context, ids []uint64) (map[uint64]*pb.Fingerprint, error) {
+	if len(ids) == 0 {
+		return nil, nil
+	}
 	fps := make(map[uint64]*pb.Fingerprint, len(ids))
 	for _, id := range ids {
 		fp, err := s.Get(ctx, id)