Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard.json to use dynamic rate interval #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iustin
Copy link

@iustin iustin commented Oct 31, 2023

Per https://grafana.com/blog/2020/09/28/new-in-grafana-7.2-__rate_interval-for-prometheus-rate-queries-that-just-work/, a fixed rate interval works only in some cases. The current 1m assumes that everyone uses the default prometheus scraping interval (15s), but this is not guaranteed, so replace with $__rate_interval which should deal with things automatically in most cases.

@iustin
Copy link
Author

iustin commented Mar 5, 2024

Friendly ping.

Copy link
Owner

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SuperQ
Copy link
Owner

SuperQ commented Mar 5, 2024

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Per https://grafana.com/blog/2020/09/28/new-in-grafana-7.2-__rate_interval-for-prometheus-rate-queries-that-just-work/, a fixed rate interval works only in some cases. The current `1m` assumes that everyone uses the default prometheus scraping interval (15s), but this is not guaranteed, so replace with `$__rate_interval` which should deal with things automatically in most cases.

Signed-off-by: Iustin Pop <[email protected]>
@iustin
Copy link
Author

iustin commented Mar 5, 2024

Updated, thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants