refactor: Patch user verification code #160
Open
+130
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch introduces patches and enhancements to the current
accounts
app. This PR's primary goal was to address the logic to generate a user verification code using the standard Python librandom
which is discouraged for potentially sensitive or confidential data. For more details, seePEP506
Fixes:
N/A
Type of change
Decisions
verification_code
is coupled to thesecrets
lib. This is a minor tradeoff toensure the
random
lib is not used under the hood. A subsequent patch to decouple the util will be added soon.Testing
Test Configuration:
The following asserts newly added tests pass:
The following asserts all project tests pass:
Additional
General:
Compose
. I can make another PR to merge these patches to improve the developer experience.Checklist: