-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Poetry config files for improved dependency management #153
Add Poetry config files for improved dependency management #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Contributor,👋👋 Thank You For Opening This Pull Request 🎉🎉
Welcome to SpaceYaTech
We are the fastest growing Africa Open-Source Community Looking To Change The Way Young Africans Get Started In Technology.
JOIN US | THRIVE | GROW
It's great having you contribute to this project
Welcome to the community 🤓 🍿 **Fun facts** - we eat bugs 🐛🐛🐛🐛 for breakfast 🥣This Pull request has been queued for `review`
Sit tight the maintainers are on your case.Soon the maintainers/owner will review it and provide you with feedback suggestions.
If you think it's something urgent, feel free to reach out
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docker images need to be updated to cater for the new dependency management
- this fixes failing docker pipelines
@Gibson-Gichuru I updated the requirements file. Exported the requirements from the pyproject.toml file. This should fix the error with the workflows. |
I mean the docker file still uses the old requirements.txt to build the application. should now be using the .tml file |
This means the project is moving away from using the requirements.txt file to Poetry and the pyproject.toml file right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend using Pipenv
let's use pipenv for uniformity across all our python projects |
Let me create an issue and get working on it. |
Stale pull request message |
Description
Added a pyproject.tml file using Poetry to the project. The file contains all the current project dependencies but using Poetry enables better management of dependencies preventing issues with circular dependency and invalid dependencies.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist: