Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page tests #242

Open
wants to merge 27 commits into
base: Dev
Choose a base branch
from
Open

Landing page tests #242

wants to merge 27 commits into from

Conversation

Andrew-Ochieng
Copy link
Collaborator

Have you read the contributing guidelines ?

What is the purpose of your pull request?

  • Bug fix
  • New feature
  • Documentation

Proposed changes

Warning

Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines (read the guide below for help).

How to Check and Fix Linting Issues

Run npm run validate. This command will run prettier and eslint checks to ensure linting guidelines are respected.

  • If the command exits with code 0 (build is successful), there are no linting issues.

  • If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 10:03am

@alvyynm
Copy link
Member

alvyynm commented Sep 18, 2024

@sonylomo I've fixed the tests. All tests run successfully except one which depends on events data from the API (the API doesn't have any events data as of now) as shown here.:
7 [chromium] › pages/landing-page.spec.js:53:3 › Landing page tests › Check 'OUR EVENTS' section title, events card, and 'View More' button (6.3s)
21 [webkit] › pages/landing-page.spec.js:53:3 › Landing page tests › Check 'OUR EVENTS' section title, events card, and 'View More' button (6.3s)

By disabling checking if at least one event card is displayed, all the tests run as expected 👇:
Screenshot 2024-09-18 at 13 22 10

@Ase020 I can see your recent PR introduced some linting issue. Haven't had time to go over it, can you kindly address that? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants