Implement glutin_interface on this crate. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Freya Gentz <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
18 tasks
goddessfreya
changed the title
goddessfreya
commented
Feb 17, 2020
| bitflags = "1.2.1" | ||
| wayland-client = { version = "0.23", optional = true } | ||
| drm = { version = "0.3.4", optional = true } | ||
| glutin_interface = { version = "0.1.0", path = "../glutin_interface", optional = true } |
There was a problem hiding this comment.
@Drakulix These two lines will be fixed when the crates are published.
|
Looks good. Could you give me a quick rundown about what What about I format the master branch and you rebase your commits on top? Would that work for you? Otherwise I would like to see the commits updating the dependencies and everything related to |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting changes are all contained in the
fmtcommit, where I only rancargo fmt --alldue to being too lazy to manually format the prior commits. I can revert that commit if requested and just manually format stuff.