-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Make classic WebDriver commands/responses AOT compatible #14574
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This reverts commit b927052.
Current state of this PR:
But there is a risk I missed some primitive type (like |
User description
Description
Road to AOT compatible.
Motivation and Context
Related to #14480, fixes #13363
Types of changes
Checklist
PR Type
enhancement
Description
SerializableCommand
andDeserializableResponse
classes withJsonExtensionData
to handle additional JSON data.CommandSerializerContext
andResponseSerializerContext
to manage JSON serialization contexts.Changes walkthrough 📝
Command.cs
Enhance command serialization for AOT compatibility
dotnet/src/webdriver/Command.cs
SerializableCommand
.SerializableCommand
class withJsonExtensionData
.CommandSerializerContext
for JSON serialization context.Response.cs
Improve response serialization for AOT compatibility
dotnet/src/webdriver/Response.cs
ResponseSerializerContext
.DeserializableResponse
class withJsonExtensionData
.ResponseSerializerContext
for JSON serialization context.