[RFC] Panic when given empty character class <[ ]> #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether the QAST node has any children to determine if it is empty. The exception are the backslash cclass nodes (\b, \n, \s, etc).
|
Is there any point in keeping these PRs here? Can they be salvaged/closed? First thing would be; I guess, to rebase to current main branch, right? |
|
Good question. I propose we look at all of the PRs in NQP / Rakudo again after RakuAST is fully integrated. It's too much of a shifting landscape at the moment, I'd say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Check whether the QAST node has any children to determine if it is
empty. The exception are the backslash cclass nodes (\b, \n, \s, etc).
When providing a fix for Rakudo Issue 1622, there was some discussion about whether the empty character class should be allowed at all (see discussion here).
Should this panic behavior be adopted as part of the official behavior of Perl 6 in future releases (6.d+) despite it being somewhat at odds with the behavior detailed in the roast before?