New rule: prefer x: Final = 42
over x: Final[Literal[42]]
#469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #468
Here it goes :)
There is an interaction between this new rule (
Y064
) andY061
(which warns forLiteral[None]
) where it's not entirely clear to me what to do. For example, in this case:you'd get both
Y064
andY061
. I think in this case turning it intox: Final = None
is probably nicer so I decided to not emitY061
ifY064
would also be emitted.On the other hand, this seems like a pretty unusual case (no examples in typeshed) so maybe it's not needed?