Y011 now ignores sentinel values #415
Conversation
|
Depends on python/typeshed#10582. |
|
This change has no effect on typeshed. 🤖🎉 |
| } | ||
| ) | ||
|
|
||
| _ALLOWED_SIMPLE_ATTRIBUTES_IN_DEFAULTS = frozenset({"sentinel"}) |
There was a problem hiding this comment.
I don't love this, since sentinel is a pretty common variable name, and it could be imported from other places. But I also understand that forcing people to use _typeshed.sentinel everywhere would be annoyingly verbose, so I'm fine with it for now.
It's on my to-do list to teach flake8-pyi about how imports work, so that we'd be able to figure out whether sentinel had actually been imported from _typeshed or not. But it'll involve a fair bit of refactoring to do that...
There was a problem hiding this comment.
Indeed, proper resolving would be great as it would also allow constructs like from _typeshed import sentinel as _sentinel. (Edit: Of course ideally, the linter would provide this information to its plugins.)
No description provided.