Skip to content

Commit

Permalink
Drop support for Python 3.8 (#500)
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexWaygood authored Sep 16, 2024
1 parent 91b163d commit a192ce1
Show file tree
Hide file tree
Showing 6 changed files with 75 additions and 114 deletions.
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#
# flake8-bugbear rules that cause too many false positives:
# B905 "`zip()` without an explicit `strict=True` parameter --
# the `strict` parameter was introduced in Python 3.10; we support Python 3.8
# the `strict` parameter was introduced in Python 3.10; we support Python 3.9
# B907 "Use !r inside f-strings instead of manual quotes" --
# produces false positives if you're surrounding things with double quotes

Expand Down
10 changes: 3 additions & 7 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,13 @@ jobs:
timeout-minutes: 5
strategy:
matrix:
python-version: ["3.8", "3.13"]
python-version: ["3.9", "3.13"]
fail-fast: false
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
# Need to use Python 3.8 for the mypy-3.8 job,
# or `ast_decompiler` isn't installed by `uv pip install -e '.[dev]'`,
# and `ast_decompiler` must be installed for the typecheck to succeed
# with `--python-version=3.8
python-version: "3.8"
python-version: "3.12"
allow-prereleases: true
- run: curl -LsSf https://astral.sh/uv/install.sh | sh
- run: uv pip install -e .[dev] --system
Expand All @@ -66,7 +62,7 @@ jobs:
strategy:
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
fail-fast: false
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repos:
rev: 24.4.2 # must match pyproject.toml
hooks:
- id: black
language_version: python3.8
language_version: python3.9
- repo: https://github.com/pycqa/isort
rev: 5.13.2 # must match pyproject.toml
hooks:
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ Bugfixes
* Don't emit Y053 for long strings inside `Literal` slices or
metadata strings inside `Annotated` slices.

Other changes:
* `flake8-pyi` no longer supports being run using Python 3.8.
As a result, it not longer depends on the third-party
`ast_decompiler` package.

## 24.6.0

Bugfixes
Expand Down
Loading

0 comments on commit a192ce1

Please sign in to comment.