This repository has been archived by the owner on Jan 4, 2024. It is now read-only.
fix(lambda): make the FxA lambda not throw on not found errors #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efixler
reviewed
Jul 18, 2023
| @@ -161,6 +161,22 @@ describe('SQS Event Handler', () => { | |||
| expect(scope.isDone()).toBeTruthy(); | |||
| }); | |||
|
|
|||
| it('returns success if a NotFoundError is returned from client-api for profile update event', async () => { | |||
There was a problem hiding this comment.
Nice tests!
I understand the implementation but don't we need to tell FxA to stop pinging for this user somehow? Or do we just expect to get these forever, if there was ever a pocket-FxA user?
There was a problem hiding this comment.
I'm going with the latter here, but I will raise it with the FxA team today.
efixler
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
There are a bunch of users that deleted their Pocket account, but retained their FxA account, however we still receive FxA webhook callbacks for the deleted users.
In this event user-api will return a NotFound error and we should mark the SQS message as successful, before we were marking this as a failure.
This should stop the errors like https://pocket.sentry.io/issues/4224409867/?project=6055107&query=is%3Aunresolved&referrer=issue-stream&stream_index=0
I'd love feedback/perspectives on:
Implementation Decisions
Deployment steps
References
JIRA ticket:
Issue:
Documentation: