Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pending for submit & modify submit is not correctly displayed #119

Merged
merged 2 commits into from
Sep 29, 2024
Merged

fix: pending for submit & modify submit is not correctly displayed #119

merged 2 commits into from
Sep 29, 2024

Conversation

shaokeyibb
Copy link
Member

mgt, [2024/9/29 23:09]
这里期望的事件发生顺序是这样的：

  1. 提交网络请求
  2. 将尚未提交的评论放进cache里面
  3. 重新渲染评论（为了显示刚刚放进去的那个）
  4. 等待网络请求返回
  5. 重新渲染评论

mgt, [2024/9/29 23:09]
之前这里用了两个race执行的promise，分别是
1 -> 2 -> 4 -> 5 和 3

@Enter-tainer Enter-tainer merged commit eaaf912 into master Sep 29, 2024
5 checks passed
@Enter-tainer Enter-tainer deleted the hikarilan/refactor-fix-race branch September 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enter-tainer Enter-tainer Enter-tainer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaokeyibb @Enter-tainer