fix: pending for submit & modify submit is not correctly displayed #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaokeyibb
reviewed
Sep 29, 2024
| @@ -243,7 +243,7 @@ export const submitComment = async ({ | |||
| pending: true, | |||
| }); | |||
| } | |||
|
|
|||
| await openCommentsPanel(); | |||
There was a problem hiding this comment.
这里不太好吧...在这种网络请求的函数做这种更改UI的调用会不会有点过耦合了
| @@ -290,6 +290,7 @@ export const _modifyComment = async ({ | |||
| ); | |||
| } | |||
|
|
|||
| await openCommentsPanel(); | |||
|
mgt/fix-race...hikarilan/refactor-fix-race 改了下，这样我觉得可能耦合度能低一点？ |
|
ok 用你的分支吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mgt, [2024/9/29 23:09]
这里期望的事件发生顺序是这样的：
mgt, [2024/9/29 23:09]
之前这里用了两个race执行的promise，分别是
1 -> 2 -> 4 -> 5 和 3