OHIF-2612: Fix ImageThumbnail unnecessary renderToCanvas calls #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngutman
commented
Nov 17, 2021
ngutman
commented
- Issue UI lags (jittery) when navigating studies with a large number of series #2612
- Don't call renderToCanvas if ImageThumbnail already loaded (to avoid unnecessary renders on every DOM change)
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
- Coverage 13.20% 13.14% -0.06%
==========================================
Files 289 289
Lines 7816 7849 +33
Branches 1510 1512 +2
==========================================
Hits 1032 1032
- Misses 5474 5505 +31
- Partials 1310 1312 +2
Continue to review full report at Codecov.
|
sedghi
reviewed
Dec 23, 2021
| @@ -86,7 +86,7 @@ function ImageThumbnail(props) { | |||
| }, [purgeCancelablePromise]); | |||
|
|
|||
| useEffect(() => { | |||
| if (image.imageId) { | |||
| if (image.imageId && isLoading) { | |||
There was a problem hiding this comment.
shouldn't we add isLoading in the dependency array of the useEffect too?
sedghi
reviewed
Dec 23, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
base has changed, read more here #3477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.