Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the "feat: MR series stack sorting #1066" pull request #2423

Open
wants to merge 15 commits into
base: v2-legacy
Choose a base branch
from

Conversation

slak44
Copy link
Contributor

@slak44 slak44 commented May 27, 2021

Hello, I've taken this old pull request, and fixed the conflicts with the current version of the viewer on master. I've also cleaned up the code a little, including fixes for the comments left by @swederik on #1066.

PR Checklist

  • Brief description of changes: should be the same functionality as the old PR
  • Links to any relevant issues: none
  • Required status checks are passing
  • User cases if changes impact the user's experience: same as old PR
  • @mention a maintainer to request a review: from old PR, @swederik, @dannyrb

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #2423 (3d300c3) into master (4b508b0) will decrease coverage by 0.08%.
The diff coverage is 2.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2423      +/-   ##
==========================================
- Coverage   13.29%   13.21%   -0.09%     
==========================================
  Files         287      287              
  Lines        7594     7663      +69     
  Branches     1442     1464      +22     
==========================================
+ Hits         1010     1013       +3     
- Misses       5336     5380      +44     
- Partials     1248     1270      +22     
Impacted Files Coverage Δ
...form/core/src/utils/isDisplaySetReconstructable.js 3.37% <0.00%> (ø)
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js 0.00% <0.00%> (ø)
platform/viewer/src/connectedComponents/Viewer.js 0.00% <0.00%> (ø)
...latform/core/src/classes/metadata/StudyMetadata.js 2.08% <4.47%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d13a7...3d300c3. Read the comment docs.

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Jan 3, 2022
@sedghi sedghi removed the Stale 🥖 label Jan 11, 2023
@sedghi sedghi changed the base branch from master to v2-legacy June 19, 2023 13:23
@sedghi
Copy link
Member

sedghi commented Jun 19, 2023

base has changed, read more here #3477

@sedghi sedghi added the v2-legacy OHIF v2 label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2-legacy OHIF v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants