Sanity check pip in github workflow #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pip itself uses the Python interpreter and Python libraries that it installs, it's possible that installing packages using pip can break pip and make it impossible to upgrade or downgrade packages afterwards. As a simple sanity check, try invoking the "freeze" command after installing the packages. This should catch some blatant conflicts (such as a recent issue with the cryptography package) that make pip completely non-functional.
|
thanks, looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing packages using pip can break pip for weird reasons (see issue #1915).
Add a sanity check to catch seriously broken cases before they're merged. This may be unnecessary if we stop doing pip upgrades (see issue #1921 / pull #1939) but isn't a bad idea anyway.