Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages: added Rust [WIP] #3419

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Languages: added Rust [WIP] #3419

wants to merge 3 commits into from

Conversation

Defman21
Copy link
Contributor

@Defman21 Defman21 commented Jan 5, 2018

  • Syntax Highlighting
  • Linting
  • Various integrations

CodeIntel is something I really want to implement, but the API is closed atm.

@Defman21
Copy link
Contributor Author

Defman21 commented Jan 5, 2018

Linting:

  • cargo check --message-format json --color never, capture STDOUT (STDERR does not contain any useful information); only run when a project is opened; trigger: on save; cwd: project
  • rustc --error-format=json <- OR file>, capture STDERR; only run when no project is opened; trigger: as you type; cwd: file

Integrations:

  • cargo: common commands (cargo --help)
  • rustup: common commands (rustup --help)

@Defman21
Copy link
Contributor Author

Defman21 commented Jan 6, 2018

@Naatan since cargo lints the whole project (and you can't lint a file outside of the project because of use declarations), I think I should note in the prefs that it might be slow and it requires the file to be saved?

@Naatan Naatan self-assigned this Jan 8, 2018
@Naatan Naatan added this to the 11.1 milestone Jan 8, 2018
@Naatan
Copy link
Member

Naatan commented Jan 8, 2018

@Defman21 I would go so far as to say it linting the entire project is a deal breaker. It's unlikely we'd merge it into Komodo if that's the case.

Linting happens continuously as you type, so having it spin off a super expensive lint each time would be problematic to say the least.

Regardless, thanks for the contribution! :) So you know UDL now? ;)

@Defman21
Copy link
Contributor Author

Defman21 commented Jan 8, 2018

Okay, I'll delete the entire linting then.

And yes, I know UDL now :)

@Defman21
Copy link
Contributor Author

Defman21 commented Jan 8, 2018

Actually, after thinking a bit more, I think I'll tweak the linting so it will ignore some of the errors related to import, binary/library based things such as missing fn main() declaration, etc.

@Defman21
Copy link
Contributor Author

Hmm, Rust language server supports linting, so I might use it instead of compiling files.

@Naatan Naatan modified the milestones: 11.1, 11.x.x Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants