-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repository with a pre-check role, updated meta data files and align with Ansible best practices #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…a files Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…check role Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…ional file updates Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…er meta Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
… this project Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…ook architecture Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
itsBryantP
approved these changes
Aug 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of PR complete. PR is approved under the assumption that comments will be reviewed and addressed as the author @ddimatos sees fit.
frankmit11
pushed a commit
to frankmit11/icic-ocp-upi
that referenced
this pull request
Feb 9, 2023
…ck-role Update repository with a pre-check role, updated meta data files and align with Ansible best practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather large pull request started out touching many files which had the deprecated
zos_ssh
connection plugin, given so many projects were being changed, I decided to take the opportunity and address many more issues and lay the foundation down for some future needs.This pull request:
zos_ssh
connection plugins from playbooks (breaking change if not removed)changelog.yml
to track the changes since there is really no ideal way to have official releases of this repository given a collective effort; it removes changelog entries from playbooks and transfers tochanglog.yml
.yml
over a mix of both.yml
and.yaml
inventories/
withhost_vars/*.yml
,group_vars/all.yml
and inventory.yml in an effort:group_vars/all.yml is common to all z/OS targets,
host_vars/*.ymlis aligned to target variables such that
ansible_python_interpreterhas been removed from inventory to
host_vars` because it better aligns to a target than it does inventory.ansible
andansible-console
will only look for group_vars/ and host_vars/ in the inventory directory.runtime-requirements.yml
PYZ
in host_varssite.yml
for nearly all projects, at minimum any remaining projects should consider the same and call thepre-check-role
to ensure a user who might not see the documentations requirements at least have it programmatically caught to ensure a better experience.host_setup
because the artifacts (*_vars, inventory) it generates does not adhere to the latest architecture changes, it also does not leverage the updated meta data thus there always being a need to keep updating this, a future edition will be created that is more dynamic and works with this change. Its value is debatable, configuration has been reduced to 4 variables be configured by the user, given how simple it is to configure Ansible, it may not be worth introducing it again..gitignore
to block archive formats