Feature/encoder decoder factory #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosGomes98
requested review from
Joao-L-S-Almeida,
paolofraccaro and
PedroConrado
Signed-off-by: Carlos Gomes <[email protected]> Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
CarlosGomes98
force-pushed
the
feature/encoder_decoder_factory
branch
from
b509424
to
26cb112
Compare
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
Signed-off-by: Carlos Gomes <[email protected]>
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses #135
It does quite a few things:
As future steps after this is merged, a lot of existing factories can either be removed / deprecated (as with PrithviModelFactory) or simplified greatly.
This PR does not break PrithviModelFactory, but modifies it to use the EncoderDecoderFactory. It is marked as deprecated and should be removed in the future. But for now this should not break any back compatibility.