Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend/wxc #179

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Extend/wxc #179

wants to merge 18 commits into from

Conversation

Joao-L-S-Almeida
Copy link
Member

No description provided.

@Joao-L-S-Almeida
Updating names
6eca1a4 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Option for freezing encoder and decoder
c094791 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Trying to run a fit process freezing encoder
5d33c52 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Test script for wcx
3434666 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Updates
a87df2c 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Updates
8158889 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Updates
1bb43d1 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging
980ee35 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Sep 30, 2024
@Joao-L-S-Almeida
Reduction needs be used after loss evaluation
91dc2bf 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Testing the logging
8dd6213 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Copy link
Member Author

The fine-tuning already works for the programmatic interface. See terratorch/examples/scripts/WxCTrain.py

@Joao-L-S-Almeida Joao-L-S-Almeida marked this pull request as ready for review October 7, 2024 13:41
@Joao-L-S-Almeida
Copy link
Member Author

WARNING. If this PR isn't approved (or rejected) within 7 days it will be approved as is.

@romeokienzler
Copy link
Collaborator

@Joao-L-S-Almeida generally lvgtm! thanks so much! added 3-4 comments, in case u wanna have a quick look?

@Joao-L-S-Almeida
torch <= 2.4.0 to guarantee backward compatibility
a4697a1 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Logging not printing
b898ac3 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Better name for self.hparams_
384eae7 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
This choice for reduction is not really necessary
ff33a88 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
torch.Any is deprecated
ea1c5de 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
torch can be 2.5.0
1316272 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
CarlosGomes98
CarlosGomes98 reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@CarlosGomes98 CarlosGomes98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments from my side, but overall lgtm

examples/scripts/WxCTrain.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
terratorch/datamodules/merra2_downscale.py Show resolved Hide resolved
terratorch/models/wxc_model_factory.py Outdated Show resolved Hide resolved
terratorch/tasks/wxc_downscaling_task.py Show resolved Hide resolved
terratorch/tasks/wxc_downscaling_task.py Show resolved Hide resolved
terratorch/tasks/wxc_downscaling_task.py Outdated Show resolved Hide resolved
@Joao-L-S-Almeida
Minor adjusts
273cbb2 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Minor adjusts
6d402b6 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romeokienzler romeokienzler romeokienzler left review comments

@CarlosGomes98 CarlosGomes98 CarlosGomes98 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Joao-L-S-Almeida Joao-L-S-Almeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joao-L-S-Almeida @romeokienzler @CarlosGomes98