Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend/backbones decoders #145

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Extend/backbones decoders #145

wants to merge 27 commits into from

Conversation

Joao-L-S-Almeida
Copy link
Member

@Joao-L-S-Almeida Joao-L-S-Almeida commented Sep 4, 2024 •
edited
Loading

  • The factory to manage mmseg models was extended to support builtin versions of them.
  • First version of ASPPHead for regression and segmentation.
  • First version of U-Net for regression and segmentation.

@Joao-L-S-Almeida
utils module for decoders
285f662 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Basic ASPP heads
c12dd70 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Merge branch 'main' of github.com:IBM/terratorch into extend/backbone…
4446dfb 
…s_decoders
@Joao-L-S-Almeida
Merge branch 'main' into extend/backbones_decoders
ddb435a
@Joao-L-S-Almeida
Merge branch 'extend/backbones_decoders' of github.com:IBM/terratorch…
dc4c230 
… into extend/backbones_decoders
@Joao-L-S-Almeida
Testing ASPPHead decoder
c58ed36 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
First versions for the builtin ASPPHeads
783fccc 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>

Modifying factory to support both mmseg and buitin classes

Signed-off-by: João Lucas de Sousa Almeida <[email protected]>

Modifying YAML file to test ASPPHead

Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Sep 4, 2024
@Joao-L-S-Almeida Joao-L-S-Almeida linked an issue Sep 4, 2024 that may be closed by this pull request
New backbones and decoders/heads #132
Closed
@Joao-L-S-Almeida
Simplifying the ASPPHeads modules
59ee366 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Updating test
9ce74fa 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Basic architecture to add support for U-net
789bf8f 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Adapting U-Net from mmseg
c5fdfa1 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Adapting U-Net to work together with other terratorch modules
c0d4939 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>

ConvModule could have an option for transposed

Signed-off-by: João Lucas de Sousa Almeida <[email protected]>

Updating configuration

Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Testing U-Net + ASPPHead
6d634fa 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Copy link
Member Author

@Michal-Muszynski
An important question about this inclusion: are we going to possibly use ASPPHead as a single model or it will always be combined to an U-Net as a decoder head ?

@Joao-L-S-Almeida
Updating regression head for ASPP
20063e5 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Updates for ASPP regression head
17745bb 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging with main
a286a75 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Testing the option of using UpSample+Conv instead of ConvTranspose
b619735 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Adjusts and testing UpSample+Conv
343b36c 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Re-organising modules and creating terratorch/models/backbones/utils.py
ff7de3a 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Automatic tests for U-Net (they must be merged with test_pretrain.py …
9310b1d 
…in the future)

Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Copy link
Member Author

Joao-L-S-Almeida commented Sep 16, 2024 •
edited
Loading

@CarlosGomes98 @romeokienzler @Michal-Muszynski I consider it as good enough to be merged.
My questions are:

  • The current suported configs are good enough to replace mmseg for the same tasks ?
  • Are we interested in including support for more decoders than ASPP for now ?

@Joao-L-S-Almeida
Testing don't skip these tests
1fbd2bc 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
This test must be modified
e8a2b18 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
These tests are unexpectedly failing
0c523e1 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Standard config for Upsample+Conv
e617406 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Copy link
Member Author

WARNING. If this PR isn't approved (or rejected) within 7 days it will be approved as is.

@Joao-L-S-Almeida
merging
e54b046 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Merge branch 'extend/backbones_decoders' of github.com:IBM/terratorch…
d6722c0 
… into extend/backbones_decoders
@Joao-L-S-Almeida
merging
879a5cc 
Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romeokienzler romeokienzler Awaiting requested review from romeokienzler

@CarlosGomes98 CarlosGomes98 Awaiting requested review from CarlosGomes98

@Michal-Muszynski Michal-Muszynski Awaiting requested review from Michal-Muszynski

At least 1 approving review is required to merge this pull request.

Assignees

@Joao-L-S-Almeida Joao-L-S-Almeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New backbones and decoders/heads
1 participant
@Joao-L-S-Almeida