Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretrained issue #124

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Pretrained issue #124

wants to merge 4 commits into from

Conversation

Joao-L-S-Almeida
Copy link
Member

It automatically sets pretrained=False when no config is available (as for Swin).

Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@CarlosGomes98
Copy link
Collaborator

I think its safer to throw an error here and force the user to specify pretrained=False. What we can do is have the error message ask the user to do just that. In this way, the user is crystal clear on what weights area actually being loaded (or not) in the model.

@romeokienzler
Copy link
Collaborator

@Michal-Muszynski what is the reason you can't update the config file?

@biancazadrozny
Copy link
Collaborator

Need to test if during inference this error occurs when using a fine-tuned model and the backbone is not there, with this flag.

@Joao-L-S-Almeida
Copy link
Member Author

WARNING. If this PR isn't approved (or rejected) within 7 days it will be approved as is.

Signed-off-by: Joao Lucas de Sousa Almeida <[email protected]>
@romeokienzler
Copy link
Collaborator

@romeokienzler please review

@romeokienzler
Copy link
Collaborator

@Michal-Muszynski does this solve his problem?

@romeokienzler
Copy link
Collaborator

@Joao-L-S-Almeida I think there is one little problem, there rest lgtm thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model selection during inference: model flag
4 participants