Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#902: Editing the getPersonById() to stop Sting Id to int and adding more test cases to personService test #1188

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

josephbate
Copy link

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

  1. added more test in the persion and patient service classes
  2. made a change on getPersonById(String personId) to stoped coverting the id from string to interger which caused an illegal data type exception showing there is a mismatch in the parameter request

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

see: https://github.com/orgs/I-TECH-UW/projects/6/views/1?pane=issue&itemId=57668194

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@josephbate
Copy link
Author

hello @mozzy11 please go through this as

@mozzy11
Copy link
Collaborator

mozzy11 commented Jul 18, 2024

@josephbate can you see the build failure ??
Always make sure to run mvn spotless:apply to properly format your code otherwise the CI build will fail on un-formated code

Copy link

👋 Hi, @josephbate,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Jul 25, 2024
@mozzy11
Copy link
Collaborator

mozzy11 commented Aug 22, 2024

@josephbate did you see the CI build failure ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Merge Conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants