Code style enhancements and less sphinx warnings #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachriggle
reviewed
Jun 10, 2020
zachriggle
reviewed
Jun 10, 2020
zachriggle
reviewed
Jun 10, 2020
Mostly grep -Er '[=!]= (None|True|False)'
also reduced redundant characters at line ends
heapcrash
reviewed
Jun 16, 2020
heapcrash
requested changes
Jun 16, 2020
| @@ -97,11 +97,11 @@ def yesno(prompt, default=None): | |||
| cur = default | |||
| while True: | |||
| k = term.key.get() | |||
| if k in ('y', 'Y', '<left>') and cur != True: | |||
| if k in ('y', 'Y', '<left>') and cur is not True: | |||
There was a problem hiding this comment.
This should likely be not cur or similar. We should generally not check for is True or is False.
There was a problem hiding this comment.
Here the value can be either of three: True, False or None. You are probably right, if you prefer so, you can commit this further change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is several code style fixes, described in detail in this PR's commit messages.