Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub-common): fixed searchProjects to pass provided api #754

Closed
wants to merge 1 commit into from

Conversation

drspacemanphd
Copy link
Contributor

  1. Description:
  • While api was a valid option in the searchProjects signature, it was not being propagated to the underlying search request.
  1. Instructions for testing:
  • Unit tests to ensure it is propagated
  1. Closes Issues: # (if appropriate)

  2. ran commit script (npm run c)

Note If you don't run the commit script at least once, the Semantic Pull Request check will fail. Save yourself some time, and run npm run c and follow the prompts.

For more information see the README

@drspacemanphd drspacemanphd self-assigned this Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #754 (9a37ad3) into master (62791d8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #754   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          345       345           
  Lines         6528      6532    +4     
  Branches      1193      1194    +1     
=========================================
+ Hits          6528      6532    +4     
Impacted Files Coverage Δ
packages/common/src/projects/HubProjects.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8d754...9a37ad3. Read the comment docs.

@drspacemanphd
Copy link
Contributor Author

Closed this as @dbouwman will fix this in a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant