Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the nominal name #61

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Changed the nominal name #61

wants to merge 7 commits into from

Conversation

Tejoooo
Copy link

@Tejoooo Tejoooo commented Oct 7, 2023

No description provided.

@castarco
Copy link
Contributor

castarco commented Oct 14, 2023

Notes on the PR title:

  • The PR title is not representative of the change you are introducing, but of the correction I indicated in your previous PR (which was never merged). It should be adapted.

Notes on the PR description:

  • The PR description should describe the changes that you are introducing, and perhaps even adding a specific reference to the issue that you want to close. Something like " Fixes docs: add "badges" to README #36 ".

Notes on the commit messages:

  • as noted in the Contributing Guidelines, commit messages should follow the Conventional Commits style.
  • To fix that, you can use git rebase -i (git rebase interactive), and then git push --force-with-lease origin your-branch-name to change the commits in the remote version of your repository.

Notes on commit signatures:

Notes on the branch "history":

  • Ideally, it should minimise the number of commits that it containes. You can fix that by squashing commits together with git rebase -i.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants