Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86dud526g - AbstractWalletConnectEIP155Adapter - Support type 2 tr… #128

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

raulduartep
Copy link
Contributor

…ansactions and add eth_estimateGas method

@@ -182,7 +182,7 @@ importers:
specifier: ^5.7.0
version: 5.7.0
'@walletconnect/core':
specifier: ^2.13.3
specifier: 2.13.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specifier for @walletconnect/core has been changed from a caret version (^2.13.3) to a fixed version (2.13.3). This change will prevent automatic updates to newer minor and patch versions, which could be beneficial for avoiding unexpected breaking changes, but it also means missing out on potential bug fixes and improvements. If this change is intentional, ensure it aligns with the project's dependency management strategy.

@@ -191,7 +191,7 @@ importers:
specifier: 2.13.0
version: 2.13.0
'@walletconnect/web3wallet':
specifier: ^1.12.3
specifier: 1.12.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a fixed version (1.12.3) instead of a version range (^1.12.3) might prevent automatic patch updates that could include important fixes and improvements. Consider reverting to the version range if this change is not specifically required for compatibility or other reasons.

@melanke melanke merged commit e4bdf2b into main Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants