Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out thermo consistency tests #1501

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Conversation

speth
Copy link
Member

@speth speth commented Jun 12, 2023

Changes proposed in this pull request

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added Thermo tests Issues about tests, running the tests, or test results labels Jun 12, 2023
This improves the accuracy of derived properties calculated using
finite differences.
@speth speth force-pushed the breakout-consistency branch 2 times, most recently from a3a32c1 to 6280677 Compare June 12, 2023 17:41
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1501 (b1fd213) into main (13cb334) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
+ Coverage   69.48%   69.77%   +0.28%     
==========================================
  Files         377      377              
  Lines       58011    58011              
  Branches    20695    20695              
==========================================
+ Hits        40311    40479     +168     
+ Misses      14748    14577     -171     
- Partials     2952     2955       +3     
Impacted Files Coverage Δ
src/thermo/WaterPropsIAPWSphi.cpp 93.83% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @speth - apart from the new Debye-Huckel tests, I definitely appreciate separating consistency from other thermo tests, which will make the latter much more tractable.

@ischoegl ischoegl merged commit e2cdb1c into Cantera:main Jun 13, 2023
@speth speth deleted the breakout-consistency branch July 23, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues about tests, running the tests, or test results Thermo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants