Skip to content
This repository has been archived by the owner. It is now read-only.

Windows execution and build fix #84

Merged
merged 6 commits into from
Aug 14, 2021
Merged

Conversation

schlenger
Copy link
Contributor

  • Use a eslint configuration that supports Windows platforms
  • Use shx to execute UNIX commands on Windows machines
  • Updated browser list

@schlenger
Copy link
Contributor Author

s. #83

@schlenger
Copy link
Contributor Author

Also I've updated the readme according to the other issue here #82

@schlenger
Copy link
Contributor Author

@BitPhinix Any suggestions or missing things?

Copy link
Owner

@BitPhinix BitPhinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much and sorry for not looking into this sooner. It got a bit lost in my GitHub notifications. Just one small change and then we are ready to go 🚀

.eslintrc.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
Copy link
Owner

@BitPhinix BitPhinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much again 🙏

@BitPhinix
Copy link
Owner

BitPhinix commented Aug 12, 2021

There seems to be a lint issue in the eslint config 😄. You should be able to fix it using eslint --fix

@schlenger
Copy link
Contributor Author

@BitPhinix Besides the comma there was no change - I've adjusted everything according to the linter now ;)

@BitPhinix BitPhinix merged commit 12f26de into BitPhinix:master Aug 14, 2021
@schlenger schlenger deleted the windows_fix branch August 16, 2021 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants