Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README-id.md #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README-id.md #9

wants to merge 1 commit into from

Conversation

bekicot
Copy link

@bekicot bekicot commented May 31, 2017

Update readme translation to reflect fb99efb

wisn
wisn previously requested changes May 31, 2017
README-id.md Outdated
@@ -49,6 +49,9 @@ Anda dapat melihat peta yang telah dirender dari pencarian tersebut dalam berkas
`wikimedia_connected_island_relation.png` pada repo `uni-task-2`,
yang akan memperlihatkan pada Anda bahwa banyak sekali pulau-pulau di Indonesia yang tidak terdapat disana yang bisa disambungkan ke proyek-proyek Wikimedia.

Queri di atas hanya menghasilkan data dari objek terluar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sepertinya lebih baik tetap ditulis query dan dicetak miring. Kata objek tidak konsisten dengan tulisan sebelumnya yaitu obyek.

@bekicot bekicot closed this Jun 4, 2017
@bekicot
Copy link
Author

bekicot commented Jun 4, 2017

Continued in #10 . Reason: was using default github editing feature.

@jayvdb
Copy link
Member

jayvdb commented Jun 4, 2017

That is not a reason to abandon a PR.

@jayvdb jayvdb reopened this Jun 4, 2017
@bekicot
Copy link
Author

bekicot commented Jun 4, 2017

@jayvdb The email address used in the pr is not mine. It was github emails. I though by fetching and ammending the changes in new branch, i will be able to retain my email address, but it wasn't. On #10, apparently, it is still using [email protected]. Which is far from what i intended.

I should have created a better comments 😄

@jayvdb
Copy link
Member

jayvdb commented Jun 4, 2017

That is because you dont have a public email address in your GitHub profile.

But it isnt necessary. You can use git commit --amend --author="...."

@bekicot
Copy link
Author

bekicot commented Jul 4, 2017

@wisn wisn dismissed their stale review July 4, 2017 11:18

It's not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants