Added Certificates and Publications section. #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Added Certificates and publications section in CV #17 . |
BartoszJarocki
requested changes
Dec 30, 2023
certifications and publications
|
Added ResumeData Object for better readability and ease of modification. |
|
Added optional grade field in education #32 |
co-bby
reviewed
Jan 1, 2024
src/data/resume-data.tsx
Outdated
| @@ -18,8 +18,71 @@ import { | |||
| YearProgressLogo, | |||
| } from "@/images/logos"; | |||
| import { GitHubIcon, LinkedInIcon, XIcon } from "@/components/icons"; | |||
| import { StaticImageData } from "next/image"; | |||
| type ResumeData = { | |||
There was a problem hiding this comment.
I think the resume data should not have a type otherwise is going to cause a lot of problems for people who just want to fork the project and use it. some users may not have a project, websiteurl or don't want to put out location links etc.
|
PR should not contain changes to resume-data, it's my cv after all ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.