Add support for compiling in umbrella projects #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling mix compile in umbrella projects would only fail with either due lacking :caramel_paths or :caramel_release options or would not compile anything due to invalid paths. By search for files accross all sub applications files can be selected and moved to correct directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling mix compile in umbrella projects would only fail with either
due lacking :caramel_paths or :caramel_release options or would not
compile anything due to invalid paths.
By search for files accross all sub applications files can be selected
and moved to correct directory.
This is in no way a complete, or probably correct, way of doing this. My assumption was that the compiler would be called for each subapp with the correct mix project config. This is not the case for me so this workaround seems to be sufficient.
I'm not aware of the internals of Caramal. It might be a more appropriate to add an option to set the output directory in the compiler, instead of calling 'mv' manually.