Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes None tracing outputs attempted to be concatenated #973

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MaxGamill-Sheffield
Copy link
Collaborator

@MaxGamill-Sheffield MaxGamill-Sheffield commented Oct 18, 2024

Apologies, the previous PR was a tad early, I thought the "merge when ready" would wait for until tests finished...

This should provide a hotfix to the errors and similar like them:

disordered_trace_results[str(img)] = disordered_trace_result.dropna(axis=1, how="all")
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'dropna'

This occurred because the disabled modules would return None instead of an empty dataframe and we expected to have the dataframe function DataFrame.dropna() which obvs didn't exist.

This fix should ensure that dataframes are returned by disabled modules.

It also adds another exception I found when forcing the disordered traces step to fail causing KeyErrors in NodeStats and Ordered Tracing as they couldn't find the image name keys of a skeleton to grab.

Copy link
Collaborator

@SylviaWhittle SylviaWhittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much approve of the different column_sets. This makes things really clear IMO. Also love the returning an empty dataframe that is created in the same return statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants