Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Toolbar.Item and Toolbar.PopoverItem #704

Open
stropitek opened this issue Apr 3, 2024 · 2 comments
Open

Review Toolbar.Item and Toolbar.PopoverItem #704

stropitek opened this issue Apr 3, 2024 · 2 comments

Comments

@stropitek
Copy link
Contributor

We should check which props we want to expose for each of those 2 components.

Right now we are exposing too many props and we should have an intermediate private component which exposes those.

Example: isPopover should not be exposed.

@hamed-musallam
Copy link
Contributor

We shouldn't expose isPopover, and popoverInteractionKind is unnecessary for Toolbar.Item. It should be moved to the Toolbar.PopoverItem level.

@stropitek
Copy link
Contributor Author

popoverInteractionKind is unnecessary for Toolbar.Item

it is on the toolbar and that is fine IMO. I don't think a toolbar should mix different interaction kind together. It should be documented that it only affects the popover items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants