Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming is inconsistent when referring to the "global queue" and "injection queue" #6915

Open
rcoh opened this issue Oct 18, 2024 · 1 comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-metrics Module: tokio/runtime/metrics M-runtime Module: tokio/runtime

Comments

@rcoh
Copy link
Contributor

rcoh commented Oct 18, 2024

Version
Tokio 1.40

Description
The docs refer to a "global queue" but the metrics refer to an "injection queue."

These are actually the same thing and both names should be consistent.

In my opinion, "global" is a somewhat clearer name in this case (at least, it is less jargony) but I don't have a strong preference.

@rcoh rcoh added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Oct 18, 2024
@Darksonn
Copy link
Contributor

The name global queue is already used in global_queue_interval which is stable, so that's probably the one that wins.

@Darksonn Darksonn added M-runtime Module: tokio/runtime M-metrics Module: tokio/runtime/metrics labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-metrics Module: tokio/runtime/metrics M-runtime Module: tokio/runtime
Projects
None yet
Development

No branches or pull requests

2 participants