Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator/operator_controller: remove redundant logic introduced by #6427 #8697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

operator/operator_controller: remove redundant logic introduced by #6427 #8697

wants to merge 1 commit into from
+0 −4

Conversation

AndreMouche
Copy link
Member

@AndreMouche AndreMouche commented Oct 12, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8696

What is changed and how does it work?

Check List

Tests

  • Unit test

  • No code

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Oct 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andremouche, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2024
@wuhuizuo
Copy link
Contributor

/test all

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.66%. Comparing base (48e72f1) to head (8d24334).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8697      +/-   ##
==========================================
- Coverage   71.70%   71.66%   -0.04%     
==========================================
  Files         517      517              
  Lines       67450    67452       +2     
==========================================
- Hits        48364    48339      -25     
- Misses      15521    15538      +17     
- Partials     3565     3575      +10
Flag Coverage Δ
unittests 71.66% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@okJiang
Copy link
Member

okJiang commented Oct 16, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

operatror_controller:remove redundant logic introduced by #6427
3 participants
@AndreMouche @wuhuizuo @okJiang