New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create better typing around simulator options #209

Open

dagda1 opened this issue Aug 15, 2022 · 0 comments

Contributor

dagda1 commented Aug 15, 2022 •

edited

Loading

Currently, it is too easy to pass the wrong config in when creating a simulation because of this interface

export interface SimulationOptions {
  options?: Record<string, unknown>;

The code below will type check even though clientId is cased incorrectly

     createSimulation(simulator: "auth0",
      options: {
        options:{
          clientId: "[your client-id]"

This codesandbox was a quick spike for one way this could be significantly improved.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment