Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve typing in ldap simulator #194

Open
dagda1 opened this issue Apr 6, 2022 · 2 comments
Open

improve typing in ldap simulator #194

dagda1 opened this issue Apr 6, 2022 · 2 comments

Comments

@dagda1
Copy link
Contributor

dagda1 commented Apr 6, 2022

There are too many any types in the ldap simulator (most of them were added by me).

We should improve the typing.

@cowboyd
Copy link
Member

cowboyd commented Apr 7, 2022

Seems like the biggest problem is that the upstream @types/ldapjs is riddled with any.... especially on the server callbacks https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ldapjs/index.d.ts#L315-L330

Maybe the best fix is there?

GitHub
The repository for high quality TypeScript type definitions. - DefinitelyTyped/index.d.ts at master · DefinitelyTyped/DefinitelyTyped

@dagda1
Copy link
Contributor Author

dagda1 commented Apr 7, 2022

@cowboyd the types are pretty terrible, I think we can make them better without too much trouble and maybe using
declaration augmentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants