Robots and entities should take on underlying cell background unless overridden #1662
Labels
C-Moderate Effort
Should take a moderate amount of time to address.
S-Nice to have
The bug fix or feature would be nice but doesn't currently have much negative impact.
T-UI
Involves the user interface.
Z-Feature
A new feature to be added to the game.
Comments
kostmo
added
Z-Feature
This was referenced Dec 4, 2023
|
In principle I agree with this idea, although it may require changing some color schemes. There are probably some current entity/terrain color combinations that would be difficult to see. |
mergify bot
pushed a commit
that referenced
this issue
Dec 12, 2023
Towards #1662 Prerequisite for #1672 To allow a robot-occupied cell to take on the underlying terrain color as the background color of its cell, the terrain color must be representable strictly as a "background". However, currently, the `dirt`, `stone`, and `grass` terrains are represented by a half-shaded **foreground** glyph upon `black` background. Currently the ["Medium Shade" unicode character](https://www.compart.com/en/unicode/U+2592) (`▒`) is used to "blend" a somewhat bright color with a black background, resulting in a moderately dark color in the terminal for `dirt`, `stone`, and `grass`. However, these same dark colors are not reproducible in the 240-color scheme without this foreground+background blending trick; the closest approximations as a background-only or foreground-only color come out quite a bit lighter. ## Visual comparison Using: scripts/play.sh -i creative --seed 2 --autoplay | Before | After | | --- | --- | |  |  | ## Possible approaches So, we need to decide whether to: 1. Accept the new lighter colors 2. Choose new, alternative terrain colors that may be darker given the 240-color palette 3. Abandon support for 240 colors and assume "full" color terminals 4. Abandon efforts to passthrough terrain color as background of robot cells
kostmo
added
the
C-Moderate Effort
byorgey
added
the
S-Nice to have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, any entity or robot with an unspecified background attribute gets a black background by default.
A potential advantage to the current behavior, at least for robots, is better visibility contrast. However, it arguably "breaks immersion" and is less aesthetically pleasing than taking on the underlying background. And anyway it shall still be possible to explicitly set the robot's background color as a custom
attr, if desired in some scenario.The text was updated successfully, but these errors were encountered: